nada/feat: set up translation #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nada-deriv
requested review from
ali-hosseini-deriv,
yashim-deriv,
azmib-developer,
markw-deriv and
farrah-deriv
as code owners
amir-deriv
reviewed
May 8, 2024
Comment on lines
18
to
25
| PROJECT_NAME: ${{ env.VITE_PROJECT_NAME }} | ||
| CROWDIN_BRANCH_NAME: ${{ env.VITE_CROWDIN_BRANCH_NAME }} | ||
| CROWDIN_PROJECT_ID: ${{ env.VITE_CROWDIN_PROJECT_ID }} | ||
| CROWDIN_PERSONAL_TOKEN: ${{ env.VITE_CROWDIN_PERSONAL_TOKEN }} | ||
| R2_ACCOUNT_ID: ${{ env.VITE_R2_ACCOUNT_ID }} | ||
| R2_ACCESS_KEY_ID: ${{ env.VITE_R2_ACCESS_KEY_ID }} | ||
| R2_SECRET_ACCESS_KEY: ${{ env.VITE_R2_SECRET_ACCESS_KEY }} | ||
| R2_BUCKET_NAME: ${{ env.VITE_R2_BUCKET_NAME }} |
There was a problem hiding this comment.
Suggested change
| PROJECT_NAME: ${{ env.VITE_PROJECT_NAME }} | |
| CROWDIN_BRANCH_NAME: ${{ env.VITE_CROWDIN_BRANCH_NAME }} | |
| CROWDIN_PROJECT_ID: ${{ env.VITE_CROWDIN_PROJECT_ID }} | |
| CROWDIN_PERSONAL_TOKEN: ${{ env.VITE_CROWDIN_PERSONAL_TOKEN }} | |
| R2_ACCOUNT_ID: ${{ env.VITE_R2_ACCOUNT_ID }} | |
| R2_ACCESS_KEY_ID: ${{ env.VITE_R2_ACCESS_KEY_ID }} | |
| R2_SECRET_ACCESS_KEY: ${{ env.VITE_R2_SECRET_ACCESS_KEY }} | |
| R2_BUCKET_NAME: ${{ env.VITE_R2_BUCKET_NAME }} | |
| PROJECT_NAME: ${{ env.VITE_PROJECT_NAME }} | |
| CROWDIN_BRANCH_NAME: ${{ env.VITE_CROWDIN_BRANCH_NAME }} | |
| CROWDIN_PROJECT_ID: ${{ secrets.CROWDIN_PROJECT_ID }} | |
| CROWDIN_PERSONAL_TOKEN: ${{ secrets.CROWDIN_PERSONAL_TOKEN }} | |
| R2_ACCOUNT_ID: ${{ secrets.R2_ACCOUNT_ID }} | |
| R2_ACCESS_KEY_ID: ${{ secrets.R2_ACCESS_KEY_ID }} | |
| R2_SECRET_ACCESS_KEY: ${{ secrets.R2_SECRET_ACCESS_KEY }} | |
| R2_BUCKET_NAME: ${{ secrets.R2_BUCKET_NAME }} |
@nada-deriv we should add the prefix with only PROJECT_NAME and CROWDIN_BRANCH_NAME here, since only these 2 needs to be accessible in frontend and are not sensitive information, apart from these 2 variables all of them should be in secrets and without the VITE_ prefix since we don't need to access those in our frontend app
amir-deriv
reviewed
May 8, 2024
src/App.tsx
Outdated
| import AppContent from './routes/AppContent'; | ||
|
|
||
| const i18nInstance = initializeI18n({ | ||
| cdnUrl: `https://pub-5ce11fcb15f34c0a9ce8ba7086d16e6a.r2.dev/${process.env.VITE_CROWDIN_PROJECT_ID}/${process.env.VITE_CROWDIN_BRANCH_NAME}`, |
There was a problem hiding this comment.
Suggested change
| cdnUrl: `https://pub-5ce11fcb15f34c0a9ce8ba7086d16e6a.r2.dev/${process.env.VITE_CROWDIN_PROJECT_ID}/${process.env.VITE_CROWDIN_BRANCH_NAME}`, | |
| cdnUrl: `https://pub-5ce11fcb15f34c0a9ce8ba7086d16e6a.r2.dev/${process.env.VITE_PROJECT_NAME}/${process.env.VITE_CROWDIN_BRANCH_NAME}`, |
amir-deriv
suggested changes
May 8, 2024
| on: | ||
| push: | ||
| branches: | ||
| - 'main' |
There was a problem hiding this comment.
Suggested change
| - 'main' | |
| - 'master' |
|
Preview Link: https://nada-translation.deriv-p2p.pages.dev
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.